Skip to content

Add note about Guzzle throwing exceptions #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Add note about Guzzle throwing exceptions #271

merged 1 commit into from
Oct 8, 2019

Conversation

JaZo
Copy link
Contributor

@JaZo JaZo commented Oct 8, 2019

I had an issue because Guzzle was throwing exceptions for 4xx and 5xx responses and this violates PSR-18. Via Google I stumbled upon php-http/guzzle6-adapter#61 (comment) and found the cause, so the issue is fixed. However, nothing about this is mentioned in the docs, while using a custom Guzzle instance is. This PR adds the comment of php-http/guzzle6-adapter#69 to the documentation so you don't have to Google when the guzzle-adapter is suddenly violating PSR-18.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. i think we have that warning in some place already (maybe the phpdoc of the code this example is using) but this looks a likely place where people should be pointed to that fact.

@dbu dbu merged commit 3ef939e into php-http:master Oct 8, 2019
@xabbuh
Copy link
Member

xabbuh commented Oct 9, 2019

indeed, we added it to the docblock in php-http/guzzle6-adapter#69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants