Skip to content

Enhancement: Tag clients #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2019
Merged

Enhancement: Tag clients #268

merged 1 commit into from
Jul 5, 2019

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jun 21, 2019

This PR

  • adds documentation for an adjustment to the Http\HttplugBundle\DependencyInjection\HttplugExtension that will tag configured clients, allowing for retrieval (for example, in functional tests) by tag name

Related to php-http/HttplugBundle#348.

@@ -244,6 +244,32 @@ services are:
my_client:
service: 'my_custom_client_service'

.. versionadded:: 1.17
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the version here, what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, that version sounds right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dbu!

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!
i wait with merging until we merge the actual feature.

@dbu dbu merged commit b36b869 into php-http:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants