Skip to content

[Plugin] Add documentation for the VCR plugin #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2019
Merged

[Plugin] Add documentation for the VCR plugin #262

merged 3 commits into from
Apr 2, 2019

Conversation

GaryPEGEOT
Copy link
Contributor

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot! this documentation already looks very good. i added some suggestions for small improvements.

we could add some cross-referencing between the mock client: http://docs.php-http.org/en/latest/clients/mock-client.html and this page. something like mention in each that the other thing is an alternative for testing.

@GaryPEGEOT
Copy link
Contributor Author

I've addressed all the comments (unless I forgot one), also added a comment about the responses headers added by both plugins. Might need some proof reading 😄

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update. one last question:

@dbu
Copy link
Contributor

dbu commented Apr 2, 2019

can you please rebase on master? there was some change in the way we check the doc that made ci failing, i fixed it on master.

@GaryPEGEOT
Copy link
Contributor Author

can you please rebase on master? there was some change in the way we check the doc that made ci failing, i fixed it on master.

Done!

@dbu dbu merged commit 62af034 into php-http:master Apr 2, 2019
@dbu
Copy link
Contributor

dbu commented Apr 2, 2019

awesome, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants