-
Notifications
You must be signed in to change notification settings - Fork 56
[Plugin] Add documentation for the VCR plugin #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot! this documentation already looks very good. i added some suggestions for small improvements.
we could add some cross-referencing between the mock client: http://docs.php-http.org/en/latest/clients/mock-client.html and this page. something like mention in each that the other thing is an alternative for testing.
I've addressed all the comments (unless I forgot one), also added a comment about the responses headers added by both plugins. Might need some proof reading 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the update. one last question:
can you please rebase on master? there was some change in the way we check the doc that made ci failing, i fixed it on master. |
Done! |
awesome, cheers! |
See php-http/vcr-plugin#3