Skip to content

Fixed spelling error and build failure #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Fixed spelling error and build failure #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba4b99b
Fixed spelling error and build failure
Nyholm Jan 21, 2019
22cbe0b
Adding more words to the list
Nyholm Jan 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrations/symfony-bundle.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Installation
Using Symfony Flex
------------------

HttplugBundle is officialy supported by `Symfony Flex`_ and available as the ``http`` alias.
HttplugBundle is officially supported by `Symfony Flex`_ and available as the ``http`` alias.

.. code-block:: bash

Expand Down
2 changes: 1 addition & 1 deletion integrations/symfony-full-configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ This page shows an example of all configuration values provided by the bundle.
- header_append:
# Keys are the header names, values the header values
headers:
'X-FOO': bar # contrary to default symfony behaviour, hyphens "-" are NOT translated to underscores "_" for the headers.
'X-FOO': bar # contrary to default symfony behavior, hyphens "-" are NOT translated to underscores "_" for the headers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is not a spelling error. its the british vs american english ;-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know. But we have used the American spelling of this word on other places in the docs. I changed this for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, agree on the consistency.

# Set header to default value if it does not exist.
- header_defaults:
# Keys are the header names, values the header values
Expand Down
2 changes: 1 addition & 1 deletion plugins/cache.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ which allow you to specify what HTTP header you want include in the cache key.
Controlling cache listeners
```````````````````````````

One or more classes implementing ``CacheListener`` can be added through ``cache_listeners``. These classes recieve a
One or more classes implementing ``CacheListener`` can be added through ``cache_listeners``. These classes receive a
notification on whether a request was a cache hit or miss, and can optionally mutate the response based on those signals.
As an example, adding the provided ``AddHeaderCacheListener`` will mutate the response, adding an ``X-Cache`` header with
a value ``HIT`` or ``MISS``, which can be useful in debugging.
Expand Down
10 changes: 5 additions & 5 deletions plugins/retry.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ code in the 5xx server error range. Since version 2.0, responses with status
codes in the 5xx range are also retried. Each retry attempt is delayed by an
exponential backoff time.

See below for how to configure that behaviour.
See below for how to configure that behavior.

.. warning::

Expand All @@ -32,22 +32,22 @@ Options

Number of retry attempts to make before giving up.

``error_response_decider``: callable (default behaviour: retry if status code is in 5xx range)
``error_response_decider``: callable (default behavior: retry if status code is in 5xx range)

A callback function that receives the request and response to decide whether the
request should be retried.

``exception_decider``: callable (default behaviour: retry if the exception is not an HttpException or status code is in 5xx range)
``exception_decider``: callable (default behavior: retry if the exception is not an HttpException or status code is in 5xx range)

A callback function that receives a request and an exception to decide after a
failure whether the request should be retried.

``error_response_delay``: callable (default behaviour: exponential backoff)
``error_response_delay``: callable (default behavior: exponential backoff)

A callback that receives a request, a response, the current number of retries
and returns how many microseconds we should wait before trying again.

``exception_delay``: callable (default behaviour: exponential backoff)
``exception_delay``: callable (default behavior: exponential backoff)

A callback that receives a request, an exception, the current number of retries
and returns how many microseconds we should wait before trying again.
Expand Down
9 changes: 9 additions & 0 deletions spelling_word_list.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
Artax
async
auth
backoff
backtrace
boolean
callables
chunked
cURL
Diactoros
discoverable
Elasticsearch
fallback
GitHub
Expand All @@ -15,24 +17,31 @@ Liskov
Symfony
HTTPlug
Ivory
instantiation
integrations
interoperability
namespace
plugin
plugins
matchers
matcher
multipart
param
params
profiler
PHP
phpdoc
Puli
rebase
Semver
sexualized
sublicense
sync
toolbar
typehint
username
versa
versionadded
whitelist
wiki
Wikipedia
Expand Down