Skip to content

Added docs about PSR-17 and PSR-18 #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2019
Merged

Added docs about PSR-17 and PSR-18 #249

merged 3 commits into from
Jan 23, 2019

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 21, 2019

No description provided.

@Nyholm Nyholm mentioned this pull request Jan 21, 2019
Closed
@Nyholm
Copy link
Member Author

Nyholm commented Jan 21, 2019

Rebased now after #250 is merged.

dbu
dbu reviewed Jan 21, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we drop the "HTTP Client Discovery" section? or mention that it is deprecated in favour of the PSR-18 HTTP Client Discovery?

discovery.rst Outdated
@@ -13,6 +13,8 @@ Currently available discovery services:
- PSR-7 Message Factory Discovery
- PSR-7 URI Factory Discovery
- PSR-7 Stream Factory Discovery
- PSR-17 Factory Discovery
- PSR-18 Client Discovery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PSR-18 Http Client Discovery?

@Nyholm
Copy link
Member Author

Nyholm commented Jan 23, 2019

No, The HttpClientDiscovery is not deprecated. But Uri, Stream and Message Factory Discovery are.
I've changed the order and added deprecation

dbu
dbu approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dbu dbu merged commit cb6afc2 into master Jan 23, 2019
@dbu dbu deleted the Nyholm-patch-1 branch January 23, 2019 12:26
@Nyholm
Copy link
Member Author

Nyholm commented Jan 23, 2019

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @dbu