Document the most common usage of HTTPlug #227
Conversation
|
Thank you. This is the most common way to use it and it is way better then our "TODO write me" that we have now. I think it is fine to use discovery and not to instantiate the request factory manually. |
| $client = HttpClientDiscovery::find(); | ||
| $messageFactory = MessageFactoryDiscovery::find(); | ||
| $homeResponse = $client->sendRequest( | ||
| $messageFactory->createRequest('GET', 'http://httplug.io') |
I've seen several people complaining on this section being empty, and had no idea how to fill it, until today, when I wanted to write a smoke test for my application and had to figure it out. Hopefully this will get more people into HTTPlug.
greg0ire
force-pushed
the
lower_the_barrier
branch
from
f1672cc to
dfbde44
Compare
greg0ire
changed the title
|
@Nyholm fixed the commit message |
|
Ah, sorry. I was not referring to your words. "most basic" or "most common" does not really matter. I meant that this is indeed the most common/basic way to use it. It is not the "best practice" or the way one would recommend using it. Using Discovery is some convenient and I really like it. But one should rather use dependency injection to get the proper request factory or the application user should create an instance of the request factory he/she wants to use. With that said, I think the PR is perfect as it is. It is just the "tutorial"/intro page. |
|
Thanks, we should do some grep TODO, totally forget this was present |
I've seen several people complaining on this section being empty, and
had no idea how to fill it, until today, when I wanted to write a smoke
test for my application and had to figure it out.
Hopefully this will get more people into HTTPlug.