Add "Mock responses in functional tests" part #220
Conversation
There was a problem hiding this comment.
thanks a lot! good idea to document that here. i added some ideas to improve the readability.
can you please mention this section with a ..hint:: section in http://docs.php-http.org/en/latest/clients/mock-client.html to say that this client is also available as service when using symfony?
integrations/symfony-bundle.rst
Outdated
| @@ -205,6 +205,7 @@ services are: | |||
| * ``httplug.factory.guzzle6`` | |||
| * ``httplug.factory.react`` | |||
| * ``httplug.factory.socket`` | |||
| * ``httplug.factory.mock`` (Install ``php-http/mock-client``first) | |||
There was a problem hiding this comment.
i think you need a whitespace before the "first)" bit to make sphinx build this correctly
integrations/symfony-bundle.rst
Outdated
| @@ -342,6 +343,30 @@ The only steps they need is ``require`` one of the adapter implementations in | |||
| their projects ``composer.json`` and instantiating the ``HttplugBundle`` in | |||
| their kernel. | |||
|
|
|||
| Mock responses in functional tests | |||
There was a problem hiding this comment.
we use the convention of all caps in titles, this should be "Mock Responses In Functional Tests"
integrations/symfony-bundle.rst
Outdated
| @@ -342,6 +343,30 @@ The only steps they need is ``require`` one of the adapter implementations in | |||
| their projects ``composer.json`` and instantiating the ``HttplugBundle`` in | |||
| their kernel. | |||
|
|
|||
| Mock responses in functional tests | |||
| `````````````````````````````````` | |||
| To mock responses in your functional tests, proceed as follow: | |||
There was a problem hiding this comment.
s/proceed as follow/use the mock client factory in your test environement configuration/
integrations/symfony-bundle.rst
Outdated
| my_awesome_client: | ||
| factory: 'httplug.factory.mock' # replace factory | ||
|
|
||
| And in your tests: |
There was a problem hiding this comment.
To mock a response in your tests, do:
integrations/symfony-bundle.rst
Outdated
|
|
||
| // SomeWebTestCase.php | ||
| $client = static::createClient(); | ||
| // $client->disableReboot(); You might uncomment this if your client (BrowserKit) make multiple requests as kernel is rebooted on each request. |
There was a problem hiding this comment.
good idea to mention that!
lets say "If your test has the client (BrowserKit) make multiple requests, you need to disable reboot as the kernel is rebooted on each request." - and i would that put into a comment line above the commented out reboot.
integrations/symfony-bundle.rst
Outdated
| @@ -342,6 +343,30 @@ The only steps they need is ``require`` one of the adapter implementations in | |||
| their projects ``composer.json`` and instantiating the ``HttplugBundle`` in | |||
| their kernel. | |||
|
|
|||
| Mock responses in functional tests | |||
| `````````````````````````````````` | |||
There was a problem hiding this comment.
can you please addd a paragraph here that mentions again that you need the separate mock client library, and cross-link that to the clients/mock-client doc?
No description provided.