Skip to content

further clarify the third party user documentation #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2016

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Aug 3, 2016

follow up to #125

@Nyholm
Copy link
Member

Nyholm commented Aug 3, 2016

This is good and correct but I would like that this page is more "direct". More "No bullshit just tell me what to do". I think this page is different form all other documentation pages because this page should be linked from the awesome/package readme. These users just want to install the library.

Ie, "You got here because a package you like is using HTTPlug. You need to do 1, 2 and 3." And then in a note section we put the extra "Why"-things. Like the info about Virtual packages.


A different approach would be to have e TLDR with says:

"Read this page or, (if you lazy) run this command and you are good to go:"

composer require php-http/curl-client guzzlehttp/psr7 php-http/message php-http/discovery

And then have the rest of the page a little more descriptive just as the PR is.

@dbu
Copy link
Contributor Author

dbu commented Aug 3, 2016

personally, anything with less explanation would confuse me more than encourage me to use the process. but i like the TL&DR idea. it will show that its basically simple, and those people that care to understand what they are doing can read on a bit without having to hunt through the whole documentation to puzzle out what is going on. i will try to update this soonish

@dbu dbu force-pushed the improve-user-doc branch 2 times, most recently from 807bc97 to d6db8d2 Compare August 4, 2016 06:36
@dbu
Copy link
Contributor Author

dbu commented Aug 4, 2016 via email

First you need to choose library to send HTTP messages and that also provide the virtual package
`php-http/client-implementation`_. In the example
below we are using cURL.
TL&DR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbu dbu force-pushed the improve-user-doc branch from d6db8d2 to 72d0bd4 Compare August 4, 2016 06:54
@dbu
Copy link
Contributor Author

dbu commented Aug 4, 2016

thanks for the feedback, improved it

@Nyholm
Copy link
Member

Nyholm commented Aug 4, 2016

Awesome!

@Nyholm Nyholm merged commit 8d1316c into master Aug 4, 2016
@Nyholm Nyholm deleted the improve-user-doc branch August 4, 2016 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants