-
Notifications
You must be signed in to change notification settings - Fork 56
Added a note about BC #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9cf59c4
Added a note about BC
Nyholm 16b9064
syntax error
Nyholm da5dd0d
Typo
Nyholm b57689a
typo
Nyholm b3dbf8b
Better wording
Nyholm 2041fea
Removed backtick and added one more supported Puli version
Nyholm 0d08cf4
Using Christians suggestion
Nyholm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
Backwards compatibility | ||
======================= | ||
|
||
Backwards compatibility is an important topic for us, as it should be in every open source project. We follow | ||
Semver_ which allows us to only break backwards compatibility between major versions. We use | ||
deprecation notices to inform you about the changes made before they are removed. | ||
|
||
Our backwards compatibility promise does not include classes or functions with the ``@internal`` annotation. | ||
|
||
Symfony Bundle | ||
-------------- | ||
|
||
The HttplugBundle is just a Symfony integration for HTTPlug and it does not have any classes which falls under the BC | ||
promise. The backwards compatibility of the bundle is only the configuration and its values (and of course the behavior | ||
of those values). | ||
|
||
Discovery | ||
--------- | ||
|
||
The order of the strategies is not part of our BC promise. The strategies themselves are marked | ||
as ``@internal`` so they are also not part of our BC promise. | ||
However, we do promise that we will not remove a strategy neither will we remove classes from the | ||
``CommonClassesStrategy``. We will also support the following Puli versions: | ||
* 1.0.0-beta9 | ||
* 1.0.0-beta10 | ||
|
||
The consequences of the BC promise for the discovery library is that you can not rely on the *same* client to be | ||
returned in the future. However, you can be sure that if discovery finds you a client now, future updates will still | ||
find a client. | ||
|
||
.. _Semver: http://semver.org/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would simplify this sentence a bit:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any suggestions? I've already been corrected on that line: #111 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just change the current sentence with the one I put in the blockquote in my comment. But as @dbu already commented on this before, he may want to add if here actually agrees that that would be easier to read or if he preferred to keep the current sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry Christian... It was a weird comment by me.
I do like your suggestion. I hope David do not mind if I change his suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.