Skip to content

Added a note about BC #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 18, 2016
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions httplug/backwards-compatibility.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
Backwards compatibility
=======================

Backwards compatibility is an important topic for us, as it should be in every open source project. We follow
Semver_ which allows us to only break backwards compatibility between major versions. We use
deprecation notices to inform you about the changes made before they are removed.

Our backwards compatibility promise does not include classes or functions with the ``@internal`` annotation.

Symfony Bundle
--------------

The HttplugBundle is just a Symfony integration for HTTPlug and it does not have any classes which falls under the BC
promise. The backwards compatibility of the bundle is only the configuration and its values (and of course the behavior
of those values).

Discovery
---------

The order of the strategies is not part of our BC promise. The strategies themselves are marked
as ``@internal`` so they are also not part of our BC promise.
However, we do promise that we will not remove a strategy neither will we remove classes from the
``CommonClassesStrategy``. We will also support the following Puli versions:
* 1.0.0-beta9
* 1.0.0-beta10

The consequences of the BC promise for the discovery library is that you can not rely on the *same* client to be
returned in the future. However, you can be sure that if discovery finds you a client now, future updates will still
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would simplify this sentence a bit:

However, if discovery does find a client now, you can be sure that after future updates it will still discover a client.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any suggestions? I've already been corrected on that line: #111 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just change the current sentence with the one I put in the blockquote in my comment. But as @dbu already commented on this before, he may want to add if here actually agrees that that would be easier to read or if he preferred to keep the current sentence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry Christian... It was a weird comment by me.

I do like your suggestion. I hope David do not mind if I change his suggestion.

Copy link
Contributor

@dbu dbu Jul 18, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find a client.

.. _Semver: http://semver.org/
2 changes: 2 additions & 0 deletions index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ for discussion around a future HTTP client PSR.

integrations/index

Backwards compatibility <httplug/backwards-compatibility>

.. toctree::
:hidden:
:caption: Components
Expand Down