Skip to content

php 8 is stable now, and use semantic branch name #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Checks
on:
push:
branches:
- master
- "*.x"
pull_request:

jobs:
Expand Down
16 changes: 6 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: CI
on:
push:
branches:
- master
- "*.x"
pull_request:

jobs:
Expand All @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php: ['7.1', '7.2', '7.3', '7.4', '8.0']
php: ['7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2']

steps:
- name: Checkout code
Expand All @@ -25,15 +25,10 @@ jobs:
tools: composer:v2
coverage: none

- name: Install PHP 7 dependencies
run: composer update --prefer-dist --no-interaction --no-progress
if: "startsWith(matrix.php, '7.')"

- name: Install PHP 8 dependencies
- name: Install dependencies
run: |
composer require "phpdocumentor/reflection-docblock:^5.2@dev" --no-interaction --no-update
composer update --prefer-dist --prefer-stable --no-interaction --no-progress --ignore-platform-req=php
if: "startsWith(matrix.php, '8.')"
composer update --prefer-dist --no-interaction --no-progress
vendor/bin/simple-phpunit install

- name: Execute tests
run: composer test
Expand Down Expand Up @@ -61,6 +56,7 @@ jobs:
wget https://github.com/puli/cli/releases/download/1.0.0-beta9/puli.phar && chmod +x puli.phar
composer require "sebastian/comparator:^3.0.2" "puli/composer-plugin:1.0.0-beta9" --no-interaction --no-update
composer update --prefer-dist --prefer-stable --prefer-lowest --no-interaction --no-progress
vendor/bin/simple-phpunit install

- name: Execute tests
run: composer test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/installation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Installation
on:
push:
branches:
- master
- "*.x"
pull_request:

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Static analysis
on:
push:
branches:
- master
- "*.x"
pull_request:

jobs:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@
/puli.json
/vendor/
.php-cs-fixer.cache
.phpunit.result.cache
15 changes: 7 additions & 8 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "php-http/discovery",
"description": "Finds installed HTTPlug implementations and PSR-7 message factories",
"license": "MIT",
"keywords": ["http", "discovery", "client", "adapter", "message", "factory", "psr7"],
"keywords": ["http", "discovery", "client", "adapter", "message", "factory", "psr7", "psr17"],
"homepage": "http://php-http.org",
"authors": [
{
Expand All @@ -17,7 +17,8 @@
"graham-campbell/phpspec-skip-example-extension": "^5.0",
"php-http/httplug": "^1.0 || ^2.0",
"php-http/message-factory": "^1.0",
"phpspec/phpspec": "^5.1 || ^6.1"
"phpspec/phpspec": "^5.1 || ^6.1 || ^7.3",
"symfony/phpunit-bridge": "^6.2"
},
"suggest": {
"php-http/message": "Allow to use Guzzle, Diactoros or Slim Framework factories"
Expand All @@ -33,14 +34,12 @@
}
},
"scripts": {
"test": "vendor/bin/phpspec run",
"test": [
"vendor/bin/phpspec run",
"vendor/bin/simple-phpunit --group NothingInstalled"
],
"test-ci": "vendor/bin/phpspec run -c phpspec.ci.yml"
},
"extra": {
"branch-alias": {
"dev-master": "1.9-dev"
}
},
"conflict": {
"nyholm/psr7": "<1.0"
},
Expand Down
4 changes: 1 addition & 3 deletions src/Exception.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@

namespace Http\Discovery;

use Throwable;

/**
* An interface implemented by all discovery related exceptions.
*
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
*/
interface Exception extends Throwable
interface Exception extends \Throwable
{
}
1 change: 1 addition & 0 deletions src/Strategy/PuliBetaStrategy.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
* Find candidates using Puli.
*
* @internal
*
* @final
*
* @author David de Boer <david@ddeboer.nl>
Expand Down