-
Notifications
You must be signed in to change notification settings - Fork 46
Alternative to Symfony Httplug Async #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Nyholm thanks, it's works for me |
This change works for me as well. But the tests still fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is updated
Wohoo, the "install tests" are useful. I found a bug =) We still check for interfaces. Ie, Symfony client does not work without the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks!
feel free to merge and tag a new release if there is nothing else we should merge first.
Thank you |
This is a alternative to #159
Im not sure which one I like better.
This will check if a PSR17Factory can be found before accepting Symfony's HttplugClient as a candidate.