Skip to content

Alternative to Symfony Httplug Async #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 3, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 2, 2020

This is a alternative to #159

Im not sure which one I like better.

This will check if a PSR17Factory can be found before accepting Symfony's HttplugClient as a candidate.

@onEXHovia
Copy link

@Nyholm thanks, it's works for me

@XWB
Copy link

XWB commented Jan 2, 2020

This change works for me as well.

But the tests still fail.

Copy link
Member Author

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is updated

@Nyholm
Copy link
Member Author

Nyholm commented Jan 3, 2020

Wohoo, the "install tests" are useful. I found a bug =)

We still check for interfaces. Ie, Symfony client does not work without the Http\Message\RequestFactory (interface)

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

feel free to merge and tag a new release if there is nothing else we should merge first.

@Nyholm
Copy link
Member Author

Nyholm commented Jan 3, 2020

Thank you

@Nyholm Nyholm merged commit b7a424f into php-http:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants