Skip to content

Added tests and fixed issues with NoCandidateFoundException #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 5, 2019
Merged

Added tests and fixed issues with NoCandidateFoundException #132

merged 9 commits into from
Jan 5, 2019

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 5, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #131
Documentation
License MIT

I added some PHPUnit tests.

@Nyholm Nyholm mentioned this pull request Jan 5, 2019
Closed
dbu
dbu approved these changes Jan 5, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! tests for the win!

@dbu dbu merged commit a2a00ec into master Jan 5, 2019
@dbu dbu deleted the patch-exception branch January 5, 2019 17:08
@Nyholm
Copy link
Member Author

Nyholm commented Jan 5, 2019

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Array to string on exception..
2 participants
@Nyholm @dbu