Skip to content

Removed code from nyholm/psr7 0.3.0 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2018
Merged

Removed code from nyholm/psr7 0.3.0 #123

merged 1 commit into from
Dec 30, 2018

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 29, 2018

No description provided.

@Nyholm Nyholm mentioned this pull request Dec 29, 2018
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this been released? if so, is there a risk that after updating to this version of discovery but not updating nyholm/psr7, people will have discovery no longer find anything?

@Nyholm
Copy link
Member Author

Nyholm commented Dec 30, 2018

Yes, it has been released. But it is fine because we define a conflict. https://github.com/php-http/discovery/blob/master/composer.json#L47

I made a mistake in #108

Im not sure why this line was added there

if so, is there a risk

No, there is no risk.

@dbu dbu merged commit c1b0446 into master Dec 30, 2018
@dbu dbu deleted the patch-2 branch December 30, 2018 12:02
@dbu
Copy link
Contributor

dbu commented Dec 30, 2018

ah cool, the conflict declaration makes this safe.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 30, 2018

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants