full support to PHP 8.0 + add support for CurlHandle resource objects #71
Conversation
ildyria
changed the title
|
Full CI run here: https://github.com/ildyria/curl-client/actions/runs/413449950 |
|
@dbu fixed as per requested. CI Run here: https://github.com/ildyria/curl-client/actions/runs/416459080 |
|
thanks a lot, this is coming good! as you expected, the coverage fails in your repository. i will merge and see if it works from our repository. |
| restore-keys: ${{ runner.os }}-composer- | ||
|
|
||
| - name: Composer self update | ||
| run: composer self-update |
There was a problem hiding this comment.
This step should definitely not be here.
| run: composer self-update | ||
|
|
||
| - name: Install Composer dependencies | ||
| run: composer update ${{ matrix.COMPOSER_FLAGS }} --prefer-source --no-interaction |
There was a problem hiding this comment.
prefer-source will be very slow
| - name: boot test server | ||
| run: vendor/bin/http_test_server > /dev/null 2>&1 & | ||
|
|
||
| - name: Apply tests |
|
thanks for the review graham - i was so excited for php 8 that i missed those details. i do a cleanup in #74 |
|
Author of #70 - thank you for picking up it in here, I'm happy to see it merged now. I apologize about my delays in the other PR, I was having some issues lately. 🙏🏼 |
What's in this PR?
In PHP 8.0, Curl resources are changed to CurlHandle class objects. This changes DocBlock parameters and other areas where provided handles are checked with
is_resource(), which now needs to account for the replacedCurlHandleclass objects.In order to apply the test, it uses the github workflows.
Migrate from php-http/client-integration-tests from
^2.0to^3.0Why?
The author of PHP 8: Add support for CurlHandle resource objects #70 has not reacted since his PR, so nothing is moving.
Because in PHP 8.0, Curl handles are no longer resources, and this libraries
is_resourceno longer return true for valid Curl handlers.Migrate from php-http/client-integration-tests so that PHP 8.0 is supported.
Example Usage