fix phpstan errors #209
Merged
fix phpstan errors #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Jul 3, 2021
| count: 1 | ||
| path: src/HttpMethodsClient.php | ||
|
|
||
| - | ||
| message: "#^Cannot call method createStream\\(\\) on Psr\\\\Http\\\\Message\\\\StreamFactoryInterface\\|null\\.$#" | ||
| message: "#^Cannot call method isDisabled() on Http\\Client\\Common\\HttpClientPool\\HttpClientPoolItem|false\\.$#" |
dbu
commented
Jul 3, 2021
| @@ -6,14 +6,14 @@ parameters: | |||
| - src | |||
| ignoreErrors: | |||
| - | |||
| message: "#^Strict comparison using \\!\\=\\= between null and null will always evaluate to false\\.$#" | |||
| message: "#^Cannot call method createStream\\(\\) on Psr\\\\Http\\\\Message\\\\StreamFactoryInterface\\|null\\.$#" | |||
There was a problem hiding this comment.
this is git diff being weird. i delete the strict comparison thing for HttpMethodsClient and add the one for the RoundRobinClientPool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Adjust some phpstan configuration and better document BatchResult class.
Why?
Fix phpstan build.