Skip to content

PHP 8.0 support #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2020
Merged

PHP 8.0 support #198

merged 1 commit into from
Jul 13, 2020

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jul 6, 2020 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

I have:

  • Migrated the CI to GitHub Actions. Actions runs will only show up after PR merge.
  • Added PHP 8 to the CI and made any other needed changes.

EDIT: Actions run passes: https://github.com/GrahamCampbell/client-common/actions/runs/167144487.

@GrahamCampbell GrahamCampbell marked this pull request as draft July 6, 2020 09:58
@GrahamCampbell GrahamCampbell marked this pull request as ready for review July 7, 2020 15:19
@GrahamCampbell GrahamCampbell marked this pull request as draft July 7, 2020 19:06
@GrahamCampbell GrahamCampbell changed the title PHP 8 Support PHP 8.0 support Jul 12, 2020
dbu
dbu reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your work!

@GrahamCampbell GrahamCampbell marked this pull request as ready for review July 13, 2020 09:03
@GrahamCampbell
Copy link
Contributor Author

@dbu This is ready now. :)

@dbu dbu merged commit 1faee5b into php-http:master Jul 13, 2020
@dbu
Copy link
Contributor

dbu commented Jul 13, 2020

great, thanks!

@GrahamCampbell GrahamCampbell deleted the patch-1 branch July 13, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrahamCampbell @dbu