rename decider to exception_decider to make room for response_decider in version 2 #142
Conversation
|
Feel free to merge and rebase #139 on this. |
Unfortunatelly, thanks to this implementation it is impossible to support older versions of this library by using old and new array keys in the same time because if both exists in generates an error. php-http/client-common#142
|
Sorry to say, but the deprecation handling introduced in this PR is an overkill. As I can see it makes it impossible to support >= 1.9.0 and the older versions of this library by passing both the old and the new array keys to the plugin's construction. Why throwing an exception was necessary? |
Unfortunatelly, thanks to this implementation it is impossible to support older versions of this library by using old and new array keys in the same time because if both exists it throws an exception. php-http/client-common#142
|
the exception is necessary because otherwise we would need to define a priority for redundant (and therefor potentially contradictory) options. and version 2 will no longer accept the old argument, while version 1.8 and older does not know anything about the new parameter. i think for this, you will need to distinguish versions if you need to support both 1.9 and 2, if your code instantiates this and otherwise explain the configuration to the user. |
Unfortunatelly, thanks to this implementation it is impossible to support older versions of this library by using old and new array keys in the same time because if both exists it throws an exception. php-http/client-common#142
What's in this PR?
Rename callback method in retry plugin options.
Why?
Make room for response decider in version 2.
Checklist