-
Notifications
You must be signed in to change notification settings - Fork 53
Support PSR-18 #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PSR-18 #135
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,7 +47,8 @@ public function handleRequest(RequestInterface $request, callable $next, callabl | |
$identifier = spl_object_hash((object) $first); | ||
|
||
if (!array_key_exists($identifier, $this->alteredRequests)) { | ||
$request = $request->withUri($request->getUri() | ||
$request = $request->withUri( | ||
$request->getUri() | ||
->withPath($this->uri->getPath().$request->getUri()->getPath()) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure that this is more readable than the previous formatting. should we indent this some more? or extract the argument on this line to a variable so we can put There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this change must have been suggested/automatic. I like your suggestion though. |
||
); | ||
$this->alteredRequests[$identifier] = $identifier; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should adjust the exception message too