-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
=========================================
Coverage 88.23% 88.23%
Complexity 5 5
=========================================
Files 1 1
Lines 17 17
=========================================
Hits 15 15
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Interesting |
the google maps provider expects a PSR-18 client: https://github.com/geocoder-php/google-maps-provider/blob/master/GoogleMaps.php#L27 cakephp implements PSR-18: https://github.com/cakephp/http/blob/5.x/Client.php#L104 so you can pass the cake php client directly to the geocoder provider and don't need an HTTPlug adapter anymore. its one of the last changes in the google maps provider geocoder-php/google-maps-provider@f18948f - you would need to bump the google-maps requirement to ^4.7 to have it work. |
https://github.com/dereuromark/cakephp-geo/actions/runs/7432835811/job/20225103811?pr=71 Looks like Geocoder\Http\Provider\AbstractHttpProvider also needs a new min version
|
Found it, had to constraint the PS: Shouldnt this use "abandoned" composer config to clarify this? |
thanks for checking 👍 oh, i was not aware we can put the abandoned in the composer.json. i usually change it on packagist.org - but here i don't have the permissions to do that, so i will try with composer.json |
the cakephp http client implements PSR-18, and this repository only provides the HTTPlug synchronous client which PHP-HTTP deprecated.
we should deprecate this repository and mark it as abandoned, as people should just use PSR-18 directly.
when done, update the documentation similar to php-http/documentation#318 to reflect the change.