Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

deprecate this repository #16

Merged
merged 1 commit into from
Jan 6, 2024
Merged

deprecate this repository #16

merged 1 commit into from
Jan 6, 2024

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Jan 6, 2024

the cakephp http client implements PSR-18, and this repository only provides the HTTPlug synchronous client which PHP-HTTP deprecated.

we should deprecate this repository and mark it as abandoned, as people should just use PSR-18 directly.

when done, update the documentation similar to php-http/documentation#318 to reflect the change.

@dbu dbu requested a review from dereuromark January 6, 2024 16:14
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (004bccc) 88.23% compared to head (456d07b) 88.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     88.23%   88.23%           
  Complexity        5        5           
=========================================
  Files             1        1           
  Lines            17       17           
=========================================
  Hits             15       15           
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereuromark
Copy link
Collaborator

Interesting
I am mainly still using it in https://github.com/dereuromark/cakephp-geo/blob/fb5dd9da51b3cf23ba1ff0a9e39084abbab0fb35/composer.json#L36
I wonder how that would look like without this dependency.

@dbu
Copy link
Contributor Author

dbu commented Jan 6, 2024

the google maps provider expects a PSR-18 client: https://github.com/geocoder-php/google-maps-provider/blob/master/GoogleMaps.php#L27

cakephp implements PSR-18: https://github.com/cakephp/http/blob/5.x/Client.php#L104

so you can pass the cake php client directly to the geocoder provider and don't need an HTTPlug adapter anymore.

its one of the last changes in the google maps provider geocoder-php/google-maps-provider@f18948f - you would need to bump the google-maps requirement to ^4.7 to have it work.

@dbu dbu deleted the deprecate branch January 6, 2024 17:01
@dereuromark
Copy link
Collaborator

dereuromark commented Jan 6, 2024

https://github.com/dereuromark/cakephp-geo/actions/runs/7432835811/job/20225103811?pr=71
With 4.7.0

Looks like Geocoder\Http\Provider\AbstractHttpProvider also needs a new min version

Downgrading symfony/service-contracts (v3.4.1 => v1.1.9): Extracting archive
  - Downgrading symfony/http-client-contracts (v3.4.0 => v3.0.0): Extracting archive
  - Downgrading symfony/http-client (v7.0.2 => v6.0.0): Extracting archive
  - Downgrading geocoder-php/common-http (4.6.0 => 4.4.0): Extracting archive
  - Downgrading geocoder-php/google-maps-provider (4.7.1 => 4.7.0): Extracting archive
  - Downgrading clue/stream-filter (v1.7.0 => v1.5.0): Extracting archive
  - Downgrading php-http/message (1.16.0 => 1.10.0): Extracting archive
  - Downgrading theseer/tokenizer (1.2.2 => 1.2.0): Extracting archive
  - Downgrading nikic/php-parser (v4.18.0 => v4.15.0): Extracting archive
  - Downgrading phar-io/version (3.2.1 => 3.0.2): Extracting archive
  - Downgrading myclabs/deep-copy (1.11.1 => 1.10.1): Extracting archive

@dereuromark
Copy link
Collaborator

dereuromark commented Jan 7, 2024

Found it, had to constraint the "geocoder-php/common-http": "^4.6.0", as well

PS: Shouldnt this use "abandoned" composer config to clarify this?
https://getcomposer.org/doc/04-schema.md#abandoned

@dbu
Copy link
Contributor Author

dbu commented Jan 8, 2024

thanks for checking 👍

oh, i was not aware we can put the abandoned in the composer.json. i usually change it on packagist.org - but here i don't have the permissions to do that, so i will try with composer.json

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants