Skip to content

PSR-2 compliance #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

PSR-2 compliance #25

wants to merge 4 commits into from

Conversation

tuupola
Copy link
Contributor

@tuupola tuupola commented Feb 11, 2017

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets mentioned in #24
License MIT

What's in this PR?

Makes code PSR-2 compliant with the exception of relaxing the PSR1.Methods.CamelCapsMethodName for spec files. Additionally uses short array syntax in tests as discussed in #24. Lastly adds PHPCS to vendor and enables running it via $ composer phpcs.

I know this is three things in one PR but I feel these are closely related and the last one is easy remove if it is unwanted.

PSR1.Methods.CamelCapsMethodName is ignored for tests.
See discussion in #24.
@sagikazarmark
Copy link
Member

Thanks for the contribution, although I have a few problems with it:

  • such changes should be discussed on the boilerplate repo first
  • the spec files are kind of specially treated: they follow the PHPSpec style first, then PSR-1/2: so short array syntax, line breaking apply, camel case, method visibility for example do not.

@tuupola
Copy link
Contributor Author

tuupola commented Feb 11, 2017

Ok. I though the camel case rule was the only one which should be relaxed.

@tuupola tuupola closed this Feb 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants