Skip to content
This repository was archived by the owner on Jan 6, 2024. It is now read-only.

Allow buzz-adapter to be installed for buzz client ^0.17.2 #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarioBlazek
Copy link

@MarioBlazek MarioBlazek commented Feb 6, 2020

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets none
Documentation none

| License | MIT

What's in this PR?

This PR enables buzz-adapter to be installed for Buzz client ^0.17.2.

Why?

Some of us are still stuck with Buzz 0.17.2 and we are not able to upgrade to ~1.0. Due to semantic versioning buzz-adapter version constraint ^0.15.2 won't allow Buzz 0.17.

@dbu
Copy link
Contributor

dbu commented Feb 6, 2020

looking at https://travis-ci.org/php-http/buzz-adapter/jobs/646883269?utm_medium=notification&utm_source=github_status there seems to be a problem with calling a non-existing method Buzz\Client\FileGetContents::setMaxRedirects - can you check what is happening there?

@MarioBlazek
Copy link
Author

I have checked the problem. Looks like that Buzz 0.17 went very much forward with features, the setMaxRedirects was dropped in favour of OptionsResolver, for example.

@dbu do you think is it worth updating buzz-adapter to support 0.17?

@dbu
Copy link
Contributor

dbu commented Feb 7, 2020

afaik @Nyholm is involved quite a bit with buzz, maybe he can say what he things would make sense?

@Nyholm
Copy link
Member

Nyholm commented Feb 7, 2020

Buzz 1.0 supports HTTPlug 1 and 2.
Im not sure about the diff between 0.15 and 0.17, But it makes sense that setMaxRedirects was removed to support proper config values.

Im not sure what features 0.17 brings over 0.15. ie, why would you update?

@MarioBlazek
Copy link
Author

@Nyholm current project is locked on Buzz 0.17, and I would like to add HTTPlug. But this looks like a big change to support 0.17.

Upgrading my project dependencies to support Buzz 1.0 would be a better choice, in my opinion. What do you think @Nyholm?

@Nyholm
Copy link
Member

Nyholm commented Feb 7, 2020

But this looks like a big change to support 0.17.

Im not sure. It is just a minor BC breaks from what I can recall. It may be possible (with just a few lines of code) to add support for 0.17 too.

OR, one can release a new major version of this Buzz adapter to only support 0.15.

Upgrading my project dependencies to support Buzz 1.0 would be a better choice, in my opinion. What do you think @Nyholm?

Yes, that is where I would spend my time.

@MarioBlazek
Copy link
Author

Will focus on upgrading to Buzz 1.0 then. Thank you @dbu and @Nyholm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants