Fix autodiscovery #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ### Fixed | ||
|
|
||
| - Autodiscoveryby using the appropriate discovery |
There was a problem hiding this comment.
Auto discovery by using the appropriate discovery class
|
👍 |
Use the correct discovery class as factory Disable all autodiscovery in v1.2.0 to fix it there or install an async capable client as well.
sagikazarmark
force-pushed
the
fix_discovery_factory
branch
from
1a7e1e3 to
41df6da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixes the autodiscovery feature by using the appropriate discovery class.
Why?
https://github.com/php-http/HttplugBundle/blob/v1.2.0/DependencyInjection/HttplugExtension.php#L321