Skip to content

Update guzzle client #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2016
Merged

Update guzzle client #76

merged 1 commit into from
May 18, 2016

Conversation

sagikazarmark
Copy link
Member

No description provided.

@@ -6,6 +6,10 @@

- Client factories for Buzz.

### Changed

- Guzzle 6 client now uses the new `createWithConfig` named constructor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very technical. i think for the user, its more relevant to know what that means:

  • Guzzle 6 client is now created according to the Httplug specifications with automated minimal behaviour. Make sure you configure the Httplug plugins as needed, for example if you want to get exceptions for failure HTTP status codes.

@sagikazarmark
Copy link
Member Author

@dbu anything else here from your POV?

@@ -37,6 +37,7 @@
"puli/symfony-bundle": "^1.0@beta"
},
"conflict": {
"php-http/guzzle6-adapter": "<1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure this line is needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone installs 1.0.0, Guzzle 6 factory will emit an error.

@Nyholm
Copy link
Member

Nyholm commented May 14, 2016

👍

@dbu dbu merged commit 218bed6 into master May 18, 2016
@dbu dbu deleted the guzzle_default_fix branch May 18, 2016 15:33
@dbu
Copy link
Collaborator

dbu commented May 18, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants