Added Buzz client factory #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
force-pushed
the
buzz
branch
2 times, most recently
from
54ef3af to
d24eca2
Compare
| @@ -1,5 +1,11 @@ | |||
| # Change Log | |||
|
|
|||
| ## dev-master | |||
There was a problem hiding this comment.
Ah, this hurts my eyes. 😄 Call it UNRELEASED please.
There was a problem hiding this comment.
haha. We are different you and I =)
|
Also squash please. Good to go then. |
|
Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the option resolver for this factory. That is because the Buzz Client constructor did not accept an array with config. The OptionsResolver lets me avoid lots of
isset($config['foo]).