[POC] how to not be dependent on discovery #54
Conversation
|
oh, that makes sense to me! |
| */ | ||
| private function verifyDiscoveryInstalled(ContainerBuilder $container) | ||
| { | ||
| $enabledBundles = $container->getParameter('kernel.bundles'); |
There was a problem hiding this comment.
i guess we need to fake some things for the unit tests here. we can then also test the error situation.
There was a problem hiding this comment.
I don't think we need to check against the bundle, we can check against the service as well. I think that is easier to mock.
|
For me this is the same as the interface packages with one more downside: this way you have to manually install the Puli composer plugin AND the symfony bundle as well. While the composer plugin is not necessary if you want to use puli, you can manually configure any kind of client, the symfony bundle is ALWAYS necessary in order to use Puli. |
|
Hm, it seems I was wrong. The symfony-bundle actually requires the composer plugin. In this case, it's enough to suggest and install the symfony bundle. |
POC how to not be dependent on discovery Fix unit tests Fix factory method Remove duplicated service Move discovery to compiler pass Applied fixes from StyleCI Fix puli executable Use class constant Fix puli command order Fix lowest dependency issue Fix HHVM tests Improve tests
POC how to not be dependent on discovery Fix unit tests Fix factory method Remove duplicated service Move discovery to compiler pass Applied fixes from StyleCI Fix puli executable Use class constant Fix puli command order Fix lowest dependency issue Fix HHVM tests Improve tests
This is just a proof of concept how you could do to not be dependent on discovery. This will make the dependency to puli or puli bundle optional