Remove more Symfony 4 specific code #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Nov 21, 2023
| } else { | ||
| $loader->load('services_legacy_sf4.xml'); | ||
| } | ||
| $loader->load('services_legacy.xml'); |
There was a problem hiding this comment.
we could completely remove the legacy services and mention in the changelog what the new names to use are. or prefer to do that in a separate MR?
There was a problem hiding this comment.
Sure, I can do this here. I take it, this means to also remove the service alias in the services.xml?
There was a problem hiding this comment.
Psr\Http\Client\ClientInterface should still be autowireable. so i think that should stay.
There was a problem hiding this comment.
I think I misunderstood what this when I first adjusted the xml config. Both legacy XML files triggered a deprecation if Http\Client\HttpClient was used. I first read this the wrong way and thought it created a httplug.client alias.
…r `Http\Client\HttpClient`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove more Symfony 4 specific code
Why?
Support has been removed #441
To Do
httplug.clientservice? Then I move it to the services.yaml.