Skip to content

Fix PHP 8.1 deprecation notice #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Fix PHP 8.1 deprecation notice #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c43dd2f
Fix PHP 8.1 deprecation notice
stephanvierkant Nov 10, 2021
ea487d6
Update CHANGELOG.md
stephanvierkant Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.

# 1.24.1 - TBD
- Fixed deprecation notice in PHP 8.1 by adding `= null` to `\Http\HttplugBundle\Collector\Twig\HttpMessageMarkupExtension`
-
# 1.24.0 - 2021-10-23
- Changed stopwatch category from default to "httplug", so it's more prominent on Execution timeline view
- Changed tab texts inside profiler so that it shows ports in URL in case it's non-standard
Expand Down
2 changes: 1 addition & 1 deletion src/Collector/Twig/HttpMessageMarkupExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class HttpMessageMarkupExtension extends AbstractExtension
*/
private $dumper;

public function __construct(?ClonerInterface $cloner = null, ?DataDumperInterface $dumper)
public function __construct(?ClonerInterface $cloner = null, ?DataDumperInterface $dumper = null)
{
$this->cloner = $cloner ?: new VarCloner();
$this->dumper = $dumper ?: new HtmlDumper();
Expand Down