Skip to content

Changed default logging plugin monolog channel from "app" to "httplug" #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

ostrolucky
Copy link
Collaborator

Q A
Bug fix? no
New feature? no
BC breaks? maybe, but unlikely
Deprecations? no
Related tickets
Documentation
License MIT

It's pretty non-standard that bundles are using default "app" channel. It misleads users into thinking this is a log coming from application directly and breaks most of the channel filters which assume "app" channels are coming from application directly.

Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point 👍

@dbu dbu merged commit b6cc722 into master Oct 20, 2021
@dbu dbu deleted the httplug-logging-channel branch October 20, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants