Skip to content

Fix issue with whitespaces in URL when URL in tab was copied #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

ostrolucky
Copy link
Collaborator

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
Documentation -
License MIT

What's in this PR?

When URL from here
image

was copied, result of the clipboard was http:// fe-client.ek.test /shopping_dev.php/category/7077?page_type=cgp&category_ids%5B0%5D=7077&deviceoutput=desktop&browser=firefox&browser_version=92&user_test_group=2

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

@ostrolucky ostrolucky merged commit 98cf2c5 into master Oct 4, 2021
@dbu dbu deleted the remove-whitespaces-in-url branch October 6, 2021 06:02
Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good catch! that bug must have been annoying.

@@ -2,6 +2,9 @@

The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.

# 1.23.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i usually put an - unreleased on the upcoming version to be more explicit and not confuse people who look at the changelog on github and wonder why they did not get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants