Fix dark mode design compatibility #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
force-pushed
the
fix-darkmode
branch
from
0505212 to
4c27cdf
Compare
dbu
reviewed
Oct 6, 2021
There was a problem hiding this comment.
very nice, thanks!
i would prefer to add the old values as fallback over dropping Symfony 3.4 support for just this reason. if there is a more compelling reason to drop support, i am fine with it, but having the fallback values seems easy enough to me to not need to drop it.
ostrolucky
force-pushed
the
fix-darkmode
branch
from
4c27cdf to
50e3234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Before:
Checklist
To Do