Allow PHP 8

[ddeboer]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Related tickets
Documentation
License	MIT

What's in this PR?

• Allow HttplugBundle to be installed on PHP 8.
• Remove support for guzzle6-adapter; support guzzle7-adapter instead.

Checklist

• Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
• Documentation pull request created (if not simply a bugfix)

[dbu]

do we need to build with an RC of php 8? 8.0 is not found in the ci build :-/

[dbu]

and thanks for looking into this! i am excited for php 8!

[ddeboer]

Whoa, suddenly we have all new kinds of failures. Due to Symfony 5.2?

[dbu]

i think that is a symfony upgrade, yes:

Failed asserting that exception message 'The child config "cache_pool" under "httplug.clients.test.plugins.0.cache" must be configured: This must be a service id to a service implementing Psr\Cache\CacheItemPoolInterface' contains 'The child node "cache_pool" at path "httplug.clients.test.plugins.0.cache" must be configured.'.

i think the wording changed and we have assertions on that. can you adjust the assertion? i guess we should just look for httplug.clients.test.plugins.0.cache or something, otherwise the lowest version build will fail...

[ddeboer]

Depends on php-http/stopwatch-plugin#16.

[ddeboer]

Most jobs are green now. The remaining ones have to do with testing against guzzle6-adapter (by adding it to the DEPENDENCIES env var), which tries to install Guzzle 6, which obviously conflicts with Guzzle 7 required by the default guzzle7-adapter.

[dbu]

i suggest we switch all tests to guzzle7-adapter then. we don't test the other integrations anyways. and guzzle7 should work on all php versions we allow.

[ddeboer]

Unfortunately guzzle7-adapter requires HTTPlug ^2.0, so now the test against HTTPlug 1.0 is failing. How important is it to keep that test?

[dbu]

it would be nice to know it still works. can we put the guzzle7-adapter version into a variable? maybe a global variable that says guzzle7 and then we overwrite it in the build where we need guzzle6-adapter?

[ddeboer]

@dbu Only two failing test cases left. Do you have any idea what‘s going on there?

[dbu]

almost, almost.
is it possible to install guzzle6 adapter along with guzzle7-adapter? if not, we should skip the Http\HttplugBundle\Tests\Functional\DiscoveredClientsTest::testForcedDiscovery in lowest version build (check if guzzle7-adapter is available and if not, skip)

[ddeboer]

Nope: in that case guzzlehttp/guzzle will conflict between versions 6 and 7. So I’ll skip this individual test.

But… shouldn’t the auto discovery find Guzzle6 in this case?

[ddeboer]

All green, thanks for your help!

[dbu]

great, thanks!

[dbu]

released as https://github.com/php-http/HttplugBundle/releases/tag/1.20.0