Declare strict types

[gmponos]

I could also add it as a php-cs rule but checking travis I saw that you don't check the code against php-cs

[gmponos]

Ah!.. you use pretty ci... ok.. so shall I add it? if I do I will need to enable risky rules.

[dbu]

thanks, this looks good! yeah please enable the style-ci rules for it. it won't automatically change code, so i am not too worried about "risky" rules.

[gmponos]

Added this also on this PR.

[gmponos]

Done.

[Nyholm]

Thank you.

What are the benefits of having declare(strict_types=1)?

[gmponos]

What are the benefits of having declare(strict_types=1)?

I guess today none.. but why not having it?

[Nyholm]

but why not having it?

Because if we made one small mistake, everything will break horribly. =)

[gmponos]

Because if we made one small mistake, everything will break horribly. =)

Ah.. I got to admit that you have a point and better safe than sorry.. then may I suggest in order not to get all the work lost.. to leave it for tests and interfaces? or you want to disable except if you want to have a php-cs rule for having it removed.

[dbu]

i would be for having the strict types. if we do have mistakes, people will tell us, and we can fix them. more likely, other people have mistakes and can notice and fix them. non-strictness essentially hides issues. i would see this in a new minor version, not as a patch release.

most code in the bundle is not interacted with by the user, but is about the collector and factories and such.

[dbu]

@Nyholm are you ok if we merge this? afaik it should only cause BC breaks if we have programming errors in our code, and if we do we rather know and fix them than ignoring the problem.

[Nyholm]

Fair. @gmponos, can you make sure the ci is green

[dbu]

also needs a rebase on master again, to solve conflicts :-/

[dbu]

thanks!