Skip to content

Add a Symfony client factory #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Add a Symfony client factory #373

merged 1 commit into from
Jan 3, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 26, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

This PR is blocked by #372. It will allow you to configure Symfony clients like:

httplug:
    clients:
        default:
            factory: 'httplug.factory.symfony'
            http_methods_client: true
            config:
                timeout: 4  # Symfony config
            plugins:
                - 'httplug.plugin.logger'

Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supporting the symfony client definitely makes sense, yes.

doesn't symfony provide its http client as a service already? why do we need our own factory?

@Nyholm
Copy link
Member Author

Nyholm commented Dec 27, 2019

We want to integrate with HTTPlug ecosystem, plugins, cache, bundle support etc.

@Nyholm
Copy link
Member Author

Nyholm commented Dec 28, 2019

I've rebased the PR and the tests are green

@XWB
Copy link

XWB commented Jan 2, 2020

Looks good.

Please merge and tag a new release please :)

@dbu dbu merged commit 8e7136f into master Jan 3, 2020
@dbu dbu deleted the symfony-facotry branch January 3, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants