Skip to content

use symfony flex rather than the deprecated dunglas/symfony-lock #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2019
Merged

use symfony flex rather than the deprecated dunglas/symfony-lock #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0490023
use symfony flex rather than the deprecated dunglas/symfony-lock
dbu Dec 9, 2019
09fe28b
require versions without security issues
dbu Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,15 @@ matrix:

# Test LTS versions
- php: 7.3
env: DEPENDENCIES="dunglas/symfony-lock:^3"
env: SYMFONY_REQUIRE=3.4.*
- php: 7.3
env: DEPENDENCIES="dunglas/symfony-lock:^4"
env: SYMFONY_REQUIRE=4.2.*
- php: 7.3
env: SYMFONY_REQUIRE=4.3.*
- php: 7.3
env: SYMFONY_REQUIRE=4.4.*
- php: 7.3
env: SYMFONY_REQUIRE=5.0.*

# Test with httplug 1.x clients
- php: 7.2
Expand All @@ -56,6 +62,7 @@ before_install:
- if [[ $COVERAGE != true ]]; then phpenv config-rm xdebug.ini || true; fi
- if ! [ -z "$STABILITY" ]; then composer config minimum-stability ${STABILITY}; fi;
- if ! [ -v "$DEPENDENCIES" ]; then composer require --no-update ${DEPENDENCIES}; fi;
- composer global require --no-progress --no-scripts --no-plugins symfony/flex

install:
# To be removed when this issue will be resolved: https://github.com/composer/composer/issues/5355
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@
"php-http/promise": "^1.0",
"polishsymfonycommunity/symfony-mocker-container": "^1.0",
"symfony/browser-kit": "^3.4.34 || ^4.2.12 || ^5.0",
"symfony/cache": "^3.4.34 || ^4.2.12 || ^5.0",
"symfony/cache": "^3.4.34 || ~4.2.12 || ^4.3.8 || ^5.0",
"symfony/dom-crawler": "^3.4.34 || ^4.2.12 || ^5.0",
"symfony/framework-bundle": "^3.4.34 || ^4.2.12 || ^5.0",
"symfony/http-foundation": "^3.4.34 || ^4.2.12 || ^5.0",
"symfony/http-foundation": "^3.4.34 || ~4.2.12 || ^4.3.8 || ^5.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the security warning still present with this? did i mess up or does their checker not understand all details of composer version constraints?

"symfony/phpunit-bridge": "^3.4.34 || ^4.2.12 || ^5.0",
"symfony/stopwatch": "^3.4.34 || ^4.2.12 || ^5.0",
"symfony/twig-bundle": "^3.4.34 || ^4.2.12 || ^5.0",
Expand Down