Adding Support for cache-plugins cache_listeners #361
Conversation
- fixed tests, extended by cache_listeners
- list of classes to match plugins documentation - added to config - added tests
- updated changelog
|
Not quite sure, how to handle the travis ci fails. It seems this is due to other dependencies. an composer install is not possible right now due to conflicts of SymfonyDependencyInjectionTest and phpunit. |
There was a problem hiding this comment.
thanks for this one. as far as i can see, this is indeed missing. however, we should base this on services, not on class names.
we could also support a tag for listeners and auto-tagging for all services implementing the listener class, to autoconfigure all cache plugins with the listeners. which is nice when there is only one instance of cache plugin, but becomes rather weird when there are serveral instances. i propose that at least for now, we only do the config option (but with services instead of class names), and maybe add autoconfigure later - if at all.
…ers" - switched from list of classes to list of services - removed class implementation validation in configuration
…ers" - Removed obsolete uses
…ers" - Reverted unwanted style changes (even though a additional space at string concat is really nice ;))
|
Travis CI failed in one case due to timeout of 300ms |
There was a problem hiding this comment.
i have some suggestions to simplify the code, but like where we are going with this!
weird failure in travisci, can't see how this would be related to your changes. i restarted the latest master coverage ci build to see if that now fails too: https://travis-ci.org/php-http/HttplugBundle/jobs/625545203
do you plan on also adding the documentation?
- eased expression to configure cache listeners in dependency injection - added array node for cache listeners - fixed xml config
- removed duplicated cache_listeners node from src/DependencyInjection/Configuration.php - TESTS: added multiple cache_listeners
- fixed cache listener configuration - proper usage of xml configuration
|
thank you! |
What's in this PR?
Wraps cache_listeners option of cache plugin, to enable its configuration.
Why?
Cache listeners could not have been configured using this bundle. (or - which is absolutely possible - I did not get the usage)
Example Usage
Checklist