-
Notifications
You must be signed in to change notification settings - Fork 50
Adds link to debug token. #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! only thing left imho is to make the new code clean php 7.1 with static type hints, and add a note to the changelog.
can you please add the changelog entry? i think otherwise we are good to merge. |
Yes, I will update the PR later this afternoon, including the changelog entry. |
totally missed that you had updated this. thanks, nice feature! |
What's in this PR?
If a response contains a header
X-Debug-Token-Link
, i.e. a link to a Symfony debug toolbar profiler page, a clickable link is added to easily navigate to it.Why?
This is purely for a more convenient debugging when investigating Responses from a (different) Symfony application.
Checklist