Skip to content

Enhancement: Apply void_return fixer to tests #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jun 21, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
Documentation n/a
License MIT

What's in this PR?

This PR

  • applies the void_return fixer to test code

I ran

$ php-cs-fixer fix --allow-risky=yes --diff --verbose --rules=void_return tests

Why?

We require at least PHP 7.1, so why not?

Todo

  • Should we also apply this fixer to production code?

Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, the stricter the better. i'd be in for using that on the code in src/ too, but we might need some exceptions: for everything that might bee overwritten by the user, adding : void is a BC break: https://3v4l.org/2aoJs

though the bundle should probably not have any code extension points, that would all be in the library i hope.

@dbu dbu merged commit ea6ece7 into php-http:master Jul 5, 2019
@localheinz
Copy link
Contributor Author

Thank you, @dbu!

@localheinz localheinz deleted the feature/void-return branch July 5, 2019 08:02
@dbu
Copy link
Collaborator

dbu commented Jul 5, 2019

i merged as this is an improvement. can you look if we can set up the rule in the config file and apply it for src too or if that leads to any changes that look risky?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants