Skip to content

Remove enabled key from content type plugin options #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2019
Merged

Remove enabled key from content type plugin options #334

merged 1 commit into from
Apr 18, 2019

Conversation

QuingKhaos
Copy link
Contributor

@QuingKhaos QuingKhaos commented Apr 18, 2019 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
Documentation -
License MIT

What's in this PR?

Removes the enabled key from the $config array passed to the ContentTypePlugin constructor options.

Why?

The content_type plugin configuration can be enabled and thus has an enabled option in it's configuration. If this is passed without removing the enabled key, the options resolver of the ContentTypePlugin constructor options throws an exception:

The option "enabled" does not exist. Defined options are: "size_limit", "skip_detection".

Checklist

  • Updated CHANGELOG.md to describe bugfix

dbu
dbu approved these changes Apr 18, 2019
View reviewed changes
Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dbu dbu merged commit 35d2818 into php-http:master Apr 18, 2019
@dbu
Copy link
Collaborator

dbu commented Apr 18, 2019

tagged 1.15.2 with this fix

@QuingKhaos QuingKhaos deleted the fix/content-type-plugin branch May 9, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuingKhaos @dbu