support autowire convenience clients #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
force-pushed
the
autowiring-extra-clients
branch
from
39710ca to
fb60333
Compare
Nyholm
requested changes
Jan 25, 2019
this only happens for the "default" client: the first configured client or the one called default.
dbu
force-pushed
the
autowiring-extra-clients
branch
from
fb60333 to
9863d3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this only happens for the "default" client: the first configured client or the one called default.
What's in this PR?
Autowire the convenience clients
Why?
This is the expected behaviour. We only autowire them if the default client has the decorators to avoid unexpected random autowiring.
Checklist