Skip to content

Avoid deprecated notice when using symfony/config > 4.2 #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

odolbeau
Copy link

@odolbeau odolbeau commented Dec 4, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fix #289
License MIT

CHANGELOG.md Outdated
@@ -2,6 +2,12 @@

The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.

## 1.13.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally use "unreleased" here to avoid confusion when this is not released yet.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odolbeau odolbeau force-pushed the avoid-deprecated-calls branch from 0eef08d to 40e8657 Compare December 13, 2018 14:54
@dbu dbu merged commit 480b7fa into php-http:master Dec 13, 2018
@dbu
Copy link
Collaborator

dbu commented Dec 13, 2018

thanks a lot!

@dbu
Copy link
Collaborator

dbu commented Dec 13, 2018

do you happen to have an idea whats up with the deprecation warning about phpunit? it looks like its doing something stupid internally, i was not able to find anything to avoid it from our side.

@odolbeau odolbeau deleted the avoid-deprecated-calls branch December 13, 2018 15:33
@odolbeau
Copy link
Author

Unfortunately, I don't have any idea... :/ It's the first time I see this deprecation warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deprecations with symfony 4.2
2 participants