Make underlying http client also public when configured #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example: when configuring an `acme` client that is public, it should make `httplug.client.acme.client` also public.
1 task
|
i closed #286 because i don't see the use case. similar here, i don't see the use in having this internal service be public. if you really need it to be public for a special test setup, i suggest that you add a compiler pass in your application that finds the corresponding services and changes them to public after this bundle has defined them as private. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This makes the underlying http client also public when configured.
Why?
Something I didn't add in #280 but need when using mocks. This is needed for #286.
Checklist