Skip to content

Removed symfony/asset depedency by inlining js/css #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2018
Merged

Removed symfony/asset depedency by inlining js/css #251

merged 1 commit into from
Feb 4, 2018

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Feb 4, 2018

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #250
Documentation http/documentation that adds relevant documentation
License MIT

FYI @norkunas

dbu
dbu approved these changes Feb 4, 2018
View reviewed changes
Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

i guess when you rebase, the build will be green, right?

@Nyholm
Copy link
Member Author

Nyholm commented Feb 4, 2018

Yes, I've rebased now. Waiting for the tests

@fbourigault
Copy link
Contributor

Nice! Thank you!

@fbourigault fbourigault merged commit 9c1ff72 into master Feb 4, 2018
@fbourigault fbourigault deleted the issue-250 branch February 4, 2018 22:28
@Nyholm Nyholm mentioned this pull request Feb 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inline profiler styles and scripts
3 participants
@Nyholm @fbourigault @dbu