Skip to content

Add mock client factory for test purpose. #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 9, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions ClientFactory/MockFactory.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<?php

namespace Http\HttplugBundle\ClientFactory;

use Http\Mock\Client;

/**
* @author Gary PEGEOT <garypegeot@gmail.com>
*/
class MockFactory implements ClientFactory
{
/**
* @var Client
*/
private $client;

/**
* @param Client $client
*/
public function setClient(Client $client)
{
$this->client = $client;
}

/**
* {@inheritdoc}
*/
public function createClient(array $config = [])
{
if (!class_exists(Client::class)) {
throw new \LogicException('To use the mock adapter you need to install the "php-http/mock-client" package.');
}

if (!$this->client) {
$this->client = new Client();
}

return $this->client;
}
}
4 changes: 4 additions & 0 deletions DependencyInjection/HttplugExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Http\Message\Authentication\BasicAuth;
use Http\Message\Authentication\Bearer;
use Http\Message\Authentication\Wsse;
use Http\Mock\Client as MockClient;
use Psr\Http\Message\UriInterface;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ChildDefinition;
Expand Down Expand Up @@ -40,6 +41,9 @@ public function load(array $configs, ContainerBuilder $container)

$loader->load('services.xml');
$loader->load('plugins.xml');
if (\class_exists(MockClient::class)) {
$loader->load('mock-client.xml');
}

// Register default services
foreach ($config['classes'] as $service => $class) {
Expand Down
14 changes: 14 additions & 0 deletions Resources/config/mock-client.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
<container xmlns="http://symfony.com/schema/dic/services"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">

<services>
<service id="httplug.client.mock" class="Http\Mock\Client" public="true" />
<service id="httplug.factory.mock" class="Http\HttplugBundle\ClientFactory\MockFactory" public="false">
<call method="setClient">
<argument type="service" id="httplug.client.mock" />
</call>
</service>
</services>
</container>
33 changes: 33 additions & 0 deletions Tests/Unit/ClientFactory/MockFactoryTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?php
/**
* This file is part of the HttplugBundle package.
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Http\HttplugBundle\Tests\Unit\ClientFactory;

use Http\HttplugBundle\ClientFactory\MockFactory;
use Http\Mock\Client;
use PHPUnit\Framework\TestCase;

/**
* @author Gary PEGEOT <garypegeot@gmail.com>
*/
class MockFactoryTest extends TestCase
{
public function testCreateClient()
{
$factory = new MockFactory();
$client = $factory->createClient();

$this->assertInstanceOf(Client::class, $client);

$client = new Client();

$factory->setClient($client);

$this->assertEquals($client, $factory->createClient());
}
}
1 change: 1 addition & 0 deletions Tests/Unit/DependencyInjection/HttplugExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ public function testClientPlugins()
$this->assertContainerBuilderHasService($id);
}
$this->assertContainerBuilderHasServiceDefinitionWithArgument('httplug.client.acme', 1, $pluginReferences);
$this->assertContainerBuilderHasService('httplug.client.mock');
}

/**
Expand Down
3 changes: 3 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@
"conflict": {
"php-http/guzzle6-adapter": "<1.1"
},
"suggest": {
"php-http/mock-client": "Add this to your require-dev section to mock HTTP responses easily"
},
"autoload": {
"psr-4": {
"Http\\HttplugBundle\\": ""
Expand Down