Add Symfony 4 support #228
Conversation
| @@ -297,6 +298,7 @@ private function configureClient(ContainerBuilder $container, $clientName, array | |||
|
|
|||
| $container | |||
| ->register($serviceId, PluginClient::class) | |||
| ->setPublic(true) | |||
There was a problem hiding this comment.
How can we avoid to set this one public just for tests?
There was a problem hiding this comment.
Psudo code:
$services = $container->getAllServiceDefinitionKeys()
foreach ($services as $service) {
if ($service->getId() matches "httplug.client.*") {
$container->getDefinition($service)->setPublic(true);
}
}
I do not know any better... sorry
There was a problem hiding this comment.
Btw, will the tests fail if we remove this line?
There was a problem hiding this comment.
if we keep the compiler pass, this line can be reverted, right?
Tests/Resources/app/AppKernel.php
Outdated
| ]; | ||
| foreach ($services as $service) { | ||
| if ($container->hasDefinition($service)) { | ||
| $container->getDefinition($service)->setPublic(true); |
There was a problem hiding this comment.
this could be quite confusing when reading the tests, or when creating a new test. is there any chance we can instead have our tests operate on the container builder instead of the closed container?
There was a problem hiding this comment.
Yes, that's the idea but it's too many work ATM.
| @@ -297,6 +298,7 @@ private function configureClient(ContainerBuilder $container, $clientName, array | |||
|
|
|||
| $container | |||
| ->register($serviceId, PluginClient::class) | |||
| ->setPublic(true) | |||
There was a problem hiding this comment.
if we keep the compiler pass, this line can be reverted, right?
|
We are still waiting for matthiasnoback/symfony-dependency-injection-test and php-http/stopwatch-plugin to really test against Symfony 4 only components. |
| @@ -50,7 +51,7 @@ public function load(array $configs, ContainerBuilder $container) | |||
|
|
|||
| // Set main aliases | |||
| foreach ($config['main_alias'] as $type => $id) { | |||
| $container->setAlias(sprintf('httplug.%s', $type), $id); | |||
| $container->setAlias(sprintf('httplug.%s', $type), new Alias($id, true)); | |||
There was a problem hiding this comment.
the changes in this file should then be reverted too
|
I removed the public aliases. |
This is #211 with a hack to get services private in Symfony 4 without rewriting a large part of tests.
I fixedup @dbrumann commits and added mine to get @dbrumann credited.
Close #211. Close #218.
The
PublicServicesForFunctionalTestsPassis a hack and we must rewrite tests to remove this in the future.