Skip to content

turn off unneeded noise in tests #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 28, 2017

There is no need to log all notices when running tests. Seeing just critical errors is sufficient.

@Nyholm
Copy link
Member

Nyholm commented Nov 28, 2017

I do not see any difference from the output on master and this PR.
Could you show me?

@xabbuh
Copy link
Member Author

xabbuh commented Nov 28, 2017

I cannot right now. 🙈 I had expected to get version 3.4 of the HttpKernel component. But it looks like there is no requirement for this component at all.

@xabbuh xabbuh changed the title turn of unneeded noise in tests turn off unneeded noise in tests Nov 28, 2017
@xabbuh
Copy link
Member Author

xabbuh commented Nov 28, 2017

@Nyholm now you can see the difference: https://travis-ci.org/php-http/HttplugBundle/jobs/308680217 :)

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit c88d5d6 into php-http:master Nov 28, 2017
@xabbuh xabbuh deleted the silence-tests branch November 28, 2017 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants