Updated travis yml to properly test different symfony versions #221
Conversation
composer.json
Outdated
| "phpunit/php-token-stream": "^1.1.8", | ||
| "php-http/curl-client": "^1.0", | ||
| "php-http/socket-client": "^1.0", | ||
| "php-http/guzzle6-adapter": "^1.1.1", | ||
| "php-http/react-adapter": "^0.2.1", | ||
| "php-http/buzz-adapter": "^0.3", | ||
| "php-http/mock-client": "^1.0", | ||
| "symfony/phpunit-bridge": "^3.2", | ||
| "symfony/phpunit-bridge": "^3.4@rc || ^4.0", |
There was a problem hiding this comment.
that should be possible with older versions of the bridge too
There was a problem hiding this comment.
Hm.. I maybe got confused by this PR symfony/symfony#23952
There was a problem hiding this comment.
That was merged into the 3.3 branch (I forgot to update the changelog in the PR but that was fixed after merging). ^3.3 || ^4.0 should be good here.
| - php: 5.5 | ||
| env: DEPENDENCIES="symfony/lts:^2" | ||
| - php: 5.5 | ||
| env: DEPENDENCIES="symfony/lts:^3" |
There was a problem hiding this comment.
This allows some dependencies to be installed in their 2.x version. Is that wanted?
.travis.yml
Outdated
| env: DEPENDENCIES="dev" | ||
|
|
||
| allow_failures: | ||
| # Latest beta is allowed to fail. |
There was a problem hiding this comment.
This is not beta but dev-master.
.travis.yml
Outdated
| @@ -24,26 +18,47 @@ branches: | |||
| matrix: | |||
| fast_finish: true | |||
| include: | |||
| # Minimum supported PHP and Symfony version | |||
There was a problem hiding this comment.
Here PHP is the highest available version
There was a problem hiding this comment.
Yes, see symfony/symfony-docs#8701 (comment)
There was a problem hiding this comment.
So maybe a comment like Test latest PHP version with lowest dependencies would be more accurate.
|
Thank you. I did not know you could |
|
I restarted a job because it failed with a disk quota exceeded message. Build is now green. |
|
Thank you for the review |
| env: | ||
| global: | ||
| - TEST_COMMAND="composer test" | ||
| - SYMFONY_PHPUNIT_VERSION="6.3" |
There was a problem hiding this comment.
Did tests fail without exposing this environment variable? The bridge should pick the best PHPUnit version automatically if you don't do it.
There was a problem hiding this comment.
Yes, it did. It was some issues with mattiasnoback/config-test.
There was a problem hiding this comment.
Have you more details on those issues? I could look at it and maybe fix those in the library and so remove those variables from our travis file.
| - php: 7.1 | ||
| env: DEPENDENCIES="minimum" COVERAGE=true TEST_COMMAND="composer test-ci" SYMFONY_DEPRECATIONS_HELPER="weak" SYMFONY_PHPUNIT_VERSION="5.7" | ||
|
|
||
| # Test the latest stable release | ||
| - php: 5.5 |
There was a problem hiding this comment.
Not sure you need this job. There are two other jobs making use of PHP 5.5.
There was a problem hiding this comment.
Hm, maybe you are correct.
What's in this PR?
This will avoid us requiring symfony/symfony