Add reset method to collector #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbourigault
changed the title
xabbuh
approved these changes
Nov 6, 2017
|
thanks! do we need to implement an additional interface for symfony 4, or did they add a method to the interface? i am merging this: styleci fails because of yoda and we discuss that in php-http/client-common#89 and the build fails because of deprecations that are not introduced with this PR. |
|
ah, as per the build fail in #211 they added the method to the interface... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement the
DataCollectorInterface::resetmethod which will be required to get his bundle working with Symfony 4.