Skip to content

Don't use PluginClient for discovered clients #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2017
Merged

Don't use PluginClient for discovered clients #200

merged 2 commits into from
Aug 26, 2017

Conversation

fbourigault
Copy link
Contributor

@fbourigault fbourigault commented Aug 22, 2017 •
edited
Loading

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets partially #109
Documentation n/a
License MIT

This remove the need of a PluginClient for discovered clients. Only a ProfileClient is used.

This will help to avoid double profiling I'm talking about in #109.

This also contains a commit to make StyleCI happy because it now requires a blank line before break instructions.

@fbourigault fbourigault changed the title don't use PluginClient for discovered clients Don't use PluginClient for discovered clients Aug 22, 2017
@fbourigault fbourigault added this to the 1.8.0 milestone Aug 22, 2017
@fbourigault fbourigault mentioned this pull request Aug 22, 2017
Merged
5 tasks
dbu
dbu approved these changes Aug 23, 2017
View reviewed changes
Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it

@fbourigault fbourigault requested a review from Nyholm August 23, 2017 08:23
Nyholm
Nyholm approved these changes Aug 26, 2017
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@Nyholm Nyholm merged commit 33ed6ae into php-http:master Aug 26, 2017
@fbourigault fbourigault deleted the no-plugin-client-for-discovery branch August 26, 2017 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fbourigault @dbu @Nyholm