Fix profiler display when using in a symfony/flex project #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Aug 3, 2017
| @@ -45,6 +46,7 @@ | |||
| "symfony/web-profiler-bundle": "^2.8 || ^3.0", | |||
| "symfony/finder": "^2.7 || ^3.0", | |||
| "symfony/cache": "^3.1", | |||
| "symfony/browser-kit": "^2.8 || ^3.0", | |||
There was a problem hiding this comment.
We need it for testShowProfiler.
|
Thank you |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the profiler panel display when used in a symfony/flex application.
I added a test to ensure the panel is loading (the case is with no requests sent).
The bug was caused by the profiler template path which was using the old twig path syntax (no
@and::).I also found that the profiler is dependent on the
symfony/assetcomponent.