display children requests as nested in the profiler #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Jul 6, 2017
Collector/Collector.php
Outdated
| @@ -20,6 +20,11 @@ | |||
| */ | |||
| class Collector extends DataCollector | |||
| { | |||
| /** | |||
| * @var Stack | |||
Collector/Collector.php
Outdated
| * | ||
| * @param Stack $stack | ||
| */ | ||
| public function desactivateStack(Stack $stack) |
Resources/public/style/httplug.css
Outdated
| * Stack | ||
| */ | ||
| .httplug-stack>.httplug-stack { | ||
| margin-left: 35px; |
There was a problem hiding this comment.
Is 4rem a value you want as 35px is not enough? I changed it to 2.5em which is 35px on a 96dpi screen.
|
@Nyholm all yours comments have been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #109, I just discovered the refactoring I was doing allows to easily display children requests as nested in the profiler. To keep things small, I decided to do a separate PR which add a nice feature in the profiler and helps to fix #109.
This introduce the concept of active stack. When coming into the StackPlugin, the created stack is made active. Then the request go through every plugins to reach the ProfileClient. The ProfileClient deactivate the stack. Then other code execute, maybe an other request. Then when ProfileClient callbacks are executed, the stack is set as active until we reach StackPlugin callbacks where the stack is marked as inactive.
I also removed the null $stack checks as #133 is definitively solved (since #154).